Changing the local storage from SharedPreferences to Hive to demonstrate the separation of concerns#7
Open
Uuttssaavv wants to merge 1 commit intomasterfrom
Open
Changing the local storage from SharedPreferences to Hive to demonstrate the separation of concerns#7Uuttssaavv wants to merge 1 commit intomasterfrom
Uuttssaavv wants to merge 1 commit intomasterfrom
Conversation
|
i think this should be on a separate branch? |
|
Regarding the security aspect, would storing the user token in the keychain be a better option? I believe the user token should be stored in the keychain for enhanced security, while the remaining data could be stored in Hive. What are your thoughts on this approach? |
Owner
Author
Yes, for the sensitive information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean architecture provides a clear separation of concerns, encourages the use of interfaces and abstractions, and facilitates changes in the dependencies without affecting the core logic of the application.
This makes it easier to maintain, test, and extend the system over time.
With clean architecture, you can replace the SharedPreferences with Hive without affecting the core logic of the application. You would simply need to modify the data access layer, which is responsible for interacting with the data storage system. By swapping out the SharedPreferences implementation with the Hive implementation, you can change the data storage system without affecting the rest of the application.
In this PR, we simply changed the implementation and test files to change the data storage system without affecting the core logic of the application.